11 Nov
2025
11 Nov
'25
6 p.m.
On Tue, Nov 11, 2025 at 7:08 AM Miklos Szeredi miklos@szeredi.hu wrote:
On Sat, 11 Oct 2025 at 00:08, Joanne Koong joannelkoong@gmail.com wrote:
@@ -110,7 +110,9 @@ static void fuse_file_put(struct fuse_file *ff, bool sync) fuse_file_io_release(ff, ra->inode);
if (!args) {
/* Do nothing when server does not implement 'open' */
/* Do nothing when server does not implement 'opendir' */} else if (!isdir && ff->fm->fc->no_open) {How about (args->opcode == FUSE_RELEASE && ff->fm->fc->no_open) instead?
I think it's more readable here and also removes the need for multiple bool args, which can confusing.
No need to resend if you agree, I'll apply with this change.
That's a great idea. I agree, using args->opcode == FUSE_RELEASE is much better.
Thanks, Joanne
Thanks, Miklos