On Wed, Nov 6, 2024 at 1:40 PM Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
The attribute was added in GCC 4.8, while the minimum GCC version supported by the kernel is GCC 5.1.
Therefore, remove the check.
This is fine for 6.1 in the other thread, but for 5.10 here, it may not be immediately obvious it is: GCC 5.1 is not the minimum there, but 4.9, since these two are in e.g. v5.10.228:
0bddd227f3dc ("Documentation: update for gcc 4.9 requirement") 6ec4476ac825 ("Raise gcc version requirement to 4.9")
So the patch should still be good to apply, but just noting that down.
Thanks!
Cheers, Miguel