On Mon, Jan 06, 2025 at 02:18:17PM +0100, Borislav Petkov wrote:
Hi All,
Something not well baked managed to sneak in and it is tagged for stable:
adcfb264c3ed ("vmstat: disable vmstat_work on vmstat_cpu_down_prep()")
Reverting it fixes the warn splat below.
[ 0.310373] smpboot: x86: Booting SMP configuration: [ 0.311074] .... node #0, CPUs: #1 #2 #3 #4 #5 #6 #7 #8 #9 #10 #11 #12 #13 #14 #15 [ 0.313798] ------------[ cut here ]------------ [ 0.317530] workqueue: work disable count underflowed [ 0.317530] WARNING: CPU: 1 PID: 21 at kernel/workqueue.c:4317 enable_work+0xa4/0xb0 [ 0.317530] Modules linked in: [ 0.317530] CPU: 1 UID: 0 PID: 21 Comm: cpuhp/1 Not tainted 6.13.0-rc6 #11
...
JFYI, hitting the same on s390:
[ 0.176304] smp: Bringing up secondary CPUs ... [ 0.186596] ------------[ cut here ]------------ [ 0.186603] workqueue: work disable count underflowed [ 0.186606] WARNING: CPU: 1 PID: 21 at kernel/workqueue.c:4317 enable_work+0x10a/0x120 [ 0.186613] Modules linked in: [ 0.186615] CPU: 1 UID: 0 PID: 21 Comm: cpuhp/1 Not tainted 6.13.0-rc6 #206 [ 0.186619] Hardware name: IBM 3931 A01 701 (KVM/Linux) [ 0.186621] Krnl PSW : 0404c00180000000 00000308470979ee (enable_work+0x10e/0x120) [ 0.186626] R:0 T:1 IO:0 EX:0 Key:0 M:1 W:0 P:0 AS:3 CC:0 PM:0 RI:0 EA:3 [ 0.186629] Krnl GPRS: 00000308484bf9b8 00000308484bf9b0 0000000000000029 00000308484bf9b8 [ 0.186632] 000002884717ba08 000002884717ba00 000003084726e5e0 000000000073e180 [ 0.186634] 000000007fffffff 0000000000000000 0000000000000000 000000007af24840 [ 0.186637] 0000000000e3a300 0000000000e3a300 00000308470979ea 000002884717bc60 [ 0.186685] Krnl Code: 00000308470979de: c02000846cd0 larl %r2,000003084812537e [ 0.186685] 00000308470979e4: c0e5fffee146 brasl %r14,0000030847073c70 [ 0.186685] #00000308470979ea: af000000 mc 0,0 [ 0.186685] >00000308470979ee: a7080000 lhi %r0,0 [ 0.186685] 00000308470979f2: a7f4ffb2 brc 15,0000030847097956 [ 0.186685] 00000308470979f6: 0707 bcr 0,%r7 [ 0.186685] 00000308470979f8: 0707 bcr 0,%r7 [ 0.186685] 00000308470979fa: 0707 bcr 0,%r7 [ 0.186708] Call Trace: [ 0.186710] [<00000308470979ee>] enable_work+0x10e/0x120 [ 0.186714] ([<00000308470979ea>] enable_work+0x10a/0x120) [ 0.186718] [<000003084726e64c>] vmstat_cpu_online+0x6c/0x90 [ 0.186722] [<0000030847075d9a>] cpuhp_invoke_callback+0x16a/0x4d0 [ 0.186725] [<0000030847076832>] cpuhp_thread_fun+0xc2/0x250 [ 0.186728] [<00000308470a8424>] smpboot_thread_fn+0xe4/0x1b0 [ 0.186731] [<00000308470a0d46>] kthread+0x126/0x130 [ 0.186735] [<000003084702508c>] __ret_from_fork+0x3c/0x60 [ 0.186738] [<0000030847d3a582>] ret_from_fork+0xa/0x38 [ 0.186742] Last Breaking-Event-Address: [ 0.186743] [<0000030847073d62>] __warn_printk+0xf2/0x100 [ 0.186746] Kernel panic - not syncing: kernel: panic_on_warn set ... [ 0.186749] CPU: 1 UID: 0 PID: 21 Comm: cpuhp/1 Not tainted 6.13.0-rc6 #206
Thanks!