On Wed, 19 Nov 2025, Oliver Neukum wrote:
Errors in init must be reported back or we'll follow a NULL pointer the first time FF is used.
Fixes: 20eb127906709 ("hid: force feedback driver for PantherLord USB/PS2 2in1 Adapter") Cc: stable@vger.kernel.org Signed-off-by: Oliver Neukum oneukum@suse.com
drivers/hid/hid-pl.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/hid/hid-pl.c b/drivers/hid/hid-pl.c index 3c8827081dea..dc11d5322fc0 100644 --- a/drivers/hid/hid-pl.c +++ b/drivers/hid/hid-pl.c @@ -194,9 +194,14 @@ static int pl_probe(struct hid_device *hdev, const struct hid_device_id *id) goto err; }
- plff_init(hdev);
- ret = plff_init(hdev);
- if (ret)
goto stop;return 0;
+stop:
- hid_hw_stop(hdev);
err:
Thanks for the patch, makes sense and I'm going to apply it shortly.
Where is 2/2 though? I don't see it anywhere.