Re: [PATCH] drm/vc4: Fix scaling of uni-planar formats

On Mon, 07 May 2018 08:56:14 -0700 Eric Anholt eric@anholt.net wrote:

Boris Brezillon boris.brezillon@bootlin.com writes:

...

When using uni-planar formats (like RGB), the scaling parameters are stored in plane 0, not plane 1.

Fixes: fc04023fafec ("drm/vc4: Add support for YUV planes.") Cc: stable@vger.kernel.org Signed-off-by: Boris Brezillon boris.brezillon@bootlin.com

Reviewed-by: Eric Anholt eric@anholt.net

Looking at the other branch, did I get the scl0/scl1 backwards? HVS docs say for non-444 YCBCR: "In these cases Channel 0 performs Y/Alpha scaling and Channel 1 performs CB/CR scaling and should be configured as appropriate."

Didn't test, but I think rescaling of multi-planar format is correct.