On Tue, Apr 30, 2024, Greg Kroah-Hartman wrote:
On Thu, Apr 25, 2024 at 11:22:08PM +0000, Thinh Nguyen wrote:
On Thu, Apr 25, 2024, Prashanth K wrote:
diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index 4df2661f6675..666eae94524f 100644 --- a/drivers/usb/dwc3/gadget.c +++ b/drivers/usb/dwc3/gadget.c @@ -1724,8 +1724,7 @@ static int __dwc3_stop_active_transfer(struct dwc3_ep *dep, bool force, bool int dep->resource_index = 0; if (!interrupt) {
if (!DWC3_IP_IS(DWC3) || DWC3_VER_IS_PRIOR(DWC3, 310A))mdelay(1);
mdelay(1);-- 2.25.1
Acked-by: Thinh Nguyen Thinh.Nguyen@synopsys.com
This patch breaks the build on my systems:
CC [M] drivers/usb/dwc3/gadget.o drivers/usb/dwc3/gadget.c: In function ‘__dwc3_stop_active_transfer’: drivers/usb/dwc3/gadget.c:1702:22: error: unused variable ‘dwc’ [-Werror=unused-variable] 1702 | struct dwc3 *dwc = dep->dwc; | ^~~ cc1: all warnings being treated as errors
so I can't take it :(
Thanks Greg for reporting.
Hi Prashanth,
Can you resend v3 with the build fix. You can keep my Acked-by. Also, please help test and catch these issues early to avoid turn-around time.
Thanks, Thinh