On Sun, May 06, 2018 at 08:24:30PM +0200, Amit Shah wrote:
On (Thu) 03 May 2018 [22:28:32], Michael S. Tsirkin wrote:
On Thu, May 03, 2018 at 05:45:29AM +0200, Amit Shah wrote:
(apologies if you received a dup)
On (Tue) 24 Apr 2018 [21:41:29], Michael S. Tsirkin wrote:
On Fri, Apr 20, 2018 at 09:17:59PM +0300, Michael S. Tsirkin wrote:
Turns out virtio console tries to take a buffer out of an active vq. Works by sheer luck, and is explicitly forbidden by spec. And while going over it I saw that error handling is also broken - failure is easy to trigger if I force allocations to fail.
Lightly tested.
Amit - any feedback before I push these patches?
The changes look good spec-wise.
There are a bunch of tests in avocado-vt that test virtio-console functionality. Can you give those a try before pushing?
AmitI pushed before I did that test, will try to find the time later. BTW do you still want to be on the maintainers list?
Yes, I want to be on the maintainers list; but won't mind co-maintainers. The recent changes seem to be spec-related, and I'd expect you to have a good handle on that anyway.
Amit
If you can do extra testing that would be appreciated though.