Re: [PATCH v3 1/5] drm/xe/bo: fix alignment with non-4KiB kernel page sizes

Hi Simon,

Thanks for your revision, however, there is an issue with this patch.

在 2025/7/23 15:45, Simon Richter 写道:

<snip>

diff --git a/drivers/gpu/drm/xe/xe_bo.c b/drivers/gpu/drm/xe/xe_bo.c index 00ce067d5fd3..649e6d0e05a1 100644 --- a/drivers/gpu/drm/xe/xe_bo.c +++ b/drivers/gpu/drm/xe/xe_bo.c @@ -1861,9 +1861,9 @@ struct xe_bo *___xe_bo_create_locked(struct xe_device *xe, struct xe_bo *bo, flags |= XE_BO_FLAG_INTERNAL_64K; alignment = align >> PAGE_SHIFT; } else {

• aligned_size = ALIGN(size, SZ_4K);
  

• aligned_size = ALIGN(size, PAGE_SIZE);
  

  flags &= ~XE_BO_FLAG_INTERNAL_64K;

• alignment = SZ_4K >> PAGE_SHIFT;
  

• alignment = PAGE_SIZE >> PAGE_SHIFT;
  

  }

if (type == ttm_bo_type_device && aligned_size != size)

A previous change under this struct:

- bo->size = size; + bo->size = aligned_size;

Is actually still needed. Without this change, the kernel does not start up with an Intel B580.

Best Regards, Mingcong Bai