Re: [PATCH v4 1/3] x86/sgx: Split SGX_ENCL_PAGE_BEING_RECLAIMED into two flags

On Fri Jul 5, 2024 at 10:45 AM EEST, Dmitrii Kuvaiskii wrote:

SGX_ENCL_PAGE_BEING_RECLAIMED flag is set when the enclave page is being reclaimed (moved to the backing store). This flag however has two logical meanings:

~~~~~~~~ side-effects

Missing the actor.

"The page reclaimer thread sets SGX_ENC_PAGE_BEING_RECLAIMED flag..."

It is not just randomly "set".

1. Don't attempt to load the enclave page (the page is busy).

Please point out where in the source code.

2. Don't attempt to remove the PCMD page corresponding to this enclave page (the PCMD page is busy).

Please point out where in the source code.

These would be great reference when looking back.

To reflect these two meanings, split SGX_ENCL_PAGE_BEING_RECLAIMED into

I don't care about meanings. Only who does and what.

BR, Jarkko