Re: [PATCH 1/3] dt-bindings: phy: qcom-edp: Add missing clock for X Elite

On 30/07/2025 13:46, Abel Vesa wrote:

On X Elite platform, the eDP PHY uses one more clock called refclk. Add it to the schema.

And what happens if you do not provide that clock? You need to provide rationale for ABI break.

Cc: stable@vger.kernel.org # v6.10 Fixes: 5d5607861350 ("dt-bindings: phy: qcom-edp: Add X1E80100 PHY compatibles") Signed-off-by: Abel Vesa abel.vesa@linaro.org

---

.../devicetree/bindings/phy/qcom,edp-phy.yaml | 23 +++++++++++++++++++++- 1 file changed, 22 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml index 293fb6a9b1c330438bceba15226c91e392c840fb..2e594b2ea81d385118684bf58da3440c88ca32b9 100644 --- a/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml @@ -32,12 +32,14 @@ properties: - description: PLL register block clocks:

• maxItems: 2

• minItems: 2
• maxItems: 3

clock-names: items: - const: aux - const: cfg_ahb

•  - const: refclk
  

This does not match clocks. You miss minItems before the items.

"#clock-cells": const: 1 @@ -59,6 +61,25 @@ required:

• "#clock-cells"
• "#phy-cells"

+allOf:

• • if:

•  properties:
  

•    compatible:
  

•      enum:
  

•        - qcom,x1e80100-dp-phy
  

• then:

•  properties:
  

•    clocks:
  

Missing minItems... or you wanted to make it flexible, but then drop entire if branch leading only second one for other variants (maxItems: 2).

•      maxItems: 3
  

•    clock-names:
  

Same here.

•      maxItems: 3
  

• else:

•  properties:
  

•    clocks:
  

•      maxItems: 2
  

•    clock-names:
  

•      maxItems: 2
  

additionalProperties: false examples:

Best regards, Krzysztof