On Mon, Apr 28, 2025 at 07:26:57PM +0000, Ashish Kalra wrote:
There is a bug in this additional check for GHCB page contained
You don't write in the commit message that there is a bug - you explain what the bug is.
within a huge page which causes any shared page just below the per-cpu GHCB getting skipped from being transitioned back to private before kdump preparation which subsequently causes a 0x404 #VC exception when this shared page is accessed later while dumping guest memory during vmcore generation via kdump.
And you explain that *not* in a single, never-ending sentence but in simpler, smaller, more palatable sentences. Imagine you're trying to explain this to your colleagues who are not in your head.
I've been staring at the diff and trying to reverse-engineer what you're trying to tell me in the commit message and I have an idea but I'm not sure. And when I'm not sure, it often means the commit message needs more work.
So try again pls.
Thx.