Can you clarify if you suggest to leave this alone as-is in patch, or replace with something returning one of the errors above?
If the former, anything else missing in the patch?
I think the patch is O.K. Sorting out the ugly macro is a bigger job, not something for this patch.
Reviewed-by: Andrew Lunn andrew@lunn.ch
Andrew