Re: [PATCH 3/3] net: bcmgenet: synchronize UMAC_CMD access

On Thu, Apr 25, 2024 at 03:10:07PM -0700, Doug Berger wrote:

The UMAC_CMD register is written from different execution contexts and has insufficient synchronization protections to prevent possible corruption. Of particular concern are the acceses from the phy_device delayed work context used by the adjust_link call and the BH context that may be used by the ndo_set_rx_mode call.

A spinlock is added to the driver to protect contended register accesses (i.e. reg_lock) and it is used to synchronize accesses to UMAC_CMD.

Fixes: 1c1008c793fa ("net: bcmgenet: add main driver file") Cc: stable@vger.kernel.org Signed-off-by: Doug Berger opendmb@gmail.com

Reviewed-by: Simon Horman horms@kernel.org