Re: [PATCH v2] configfs: Fix config_item refcnt error in __configfs_open_file()

On Thu, Mar 11, 2021 at 12:39:40PM +0100, Christoph Hellwig wrote:

On Thu, Mar 11, 2021 at 12:35:10PM +0100, gregkh@linuxfoundation.org wrote:

...

From: Daniel Rosenberg drosen@google.com

__configfs_open_file() used to use configfs_get_config_item, but changed in commit b0841eefd969 ("configfs: provide exclusion between IO and removals") to just call to_item. The error path still tries to clean up the reference, incorrectly decrementing the ref count.

This should already be covered by:

http://git.infradead.org/users/hch/configfs.git/commitdiff/14fbbc8297728e880...

Yup, identical patch, sorry I missed that one, hopefully it hits Linus's tree soon.

thanks,

greg k-h