5 Jun
2025
5 Jun
'25
5:15 p.m.
On Thu, Jun 5, 2025 at 8:13 AM Jakub Kicinski kuba@kernel.org wrote:
On Wed, 4 Jun 2025 20:19:38 +0000 Harshitha Ramamurthy wrote:
netdev_info(dev, "Kicking queue %d", txqueue);napi_schedule(&block->napi);tx->last_kick_msec = current_time;goto out;reset: gve_schedule_reset(priv);
gotos at the base level of the function are too ugly to exit.
Please refactor this first to move the logic that decides whether reset should happen to a separate helper, then you can avoid both gotos/labels.
goto reset should turn into return true goto out should turn into return false
That makes sense to me, I'll refactor this in v2.