Re: [PATCH] x86/efi: Apply EFI Memory Attributes after kexec

On Tue Nov 12, 2024 at 7:55 AM UTC, Ard Biesheuvel wrote:

On Mon, 11 Nov 2024 at 22:45, Nicolas Saenz Julienne nsaenz@amazon.com wrote:

...

• Although care is taken to make sure the memory backing the EFI Memory Attributes table is preserved during runtime and reachable after kexec (see efi_memattr_init()). I don't see the same happening for the EFI properties table. Maybe it's just unnecessary as there's an assumption that the table will fall in memory preserved during runtime? Or for another reason? Otherwise, we'd need to make sure it isn't possible to set EFI_NX_PE_DATA on kexec.

Thanks.

I think we should just drop support for the EFI_PROPERTIES_TABLE - it was a failed, short-lived experiment that broke the boot on both Linux and Windows, and was replaced with the memory attributes table shortly after.

Isn't there a tiny posibility some platorm might be using the feature? Otherwise I'll send a v2 right away.

Nicolas