On Mon, Aug 19, 2024 at 05:48:26PM +0200, Johan Hovold wrote:
On Sun, Aug 18, 2024 at 04:17:36PM -0700, Bjorn Andersson wrote:
Amit and Johan both reported a NULL pointer dereference in the pmic_glink client code during initialization, and Stephen Boyd pointed out the problem (race condition).
In addition to the NULL pointer dereference, there is the -ECANCELED issue reported here: https://lore.kernel.org/all/Zqet8iInnDhnxkT9@hovoldconsulting.com/ I have not yet been able to either reproduce this or convince myself that this is the same issue.
I can confirm that I still see the -ECANCELED issue with this series applied:
[ 8.979329] pmic_glink_altmode.pmic_glink_altmode pmic_glink.altmode.0: failed to send altmode request: 0x10 (-125) [ 9.004735] pmic_glink_altmode.pmic_glink_altmode pmic_glink.altmode.0: failed to request altmode notifications: -125
Could you confirm that you're seeing a call to qcom_glink_handle_intent_req_ack() with granted == 0, leading to the transfer failing.
It would also be nice, just for completeness sake to rule out that you do not get a call to qcom_glink_intent_req_abort() here.
Regards, Bjorn
Johan