On Tue, Jul 01 2025, Michael Walle wrote:
Commit ff67592cbdfc ("mtd: spi-nor: Introduce spi_nor_set_mtd_info()") moved all initialization of the mtd fields at the end of spi_nor_scan(). Normally, the mtd info is only needed for the mtd ops on the device, with one exception: spi_nor_try_unlock_all(), which will also make use of the mtd->size parameter. With that commit, the size will always be zero because it is not initialized. Fix that by not using the size of the mtd_info struct, but use the size from struct spi_nor_flash_parameter.
I suppose some of this code would be cleaner if we declared a size variable instead of typing out nor->params->size every time, but I don't think it matters too much so this patch is fine too. Thanks for fixing this!
Reviewed-by: Pratyush Yadav pratyush@kernel.org
[...]