On Mon 2019-06-03 11:08:23, Greg Kroah-Hartman wrote:
From: Masahiro Yamada yamada.masahiro@socionext.com
commit e9666d10a5677a494260d60d1fa0b73cc7646eb3 upstream.
Currently, CONFIG_JUMP_LABEL just means "I _want_ to use jump label".
The jump label is controlled by HAVE_JUMP_LABEL, which is defined like this:
#if defined(CC_HAVE_ASM_GOTO) && defined(CONFIG_JUMP_LABEL) # define HAVE_JUMP_LABEL #endif
We can improve this by testing 'asm goto' support in Kconfig, then make JUMP_LABEL depend on CC_HAS_ASM_GOTO.
Ugly #ifdef HAVE_JUMP_LABEL will go away, and CONFIG_JUMP_LABEL will match to the real kernel capability.
Signed-off-by: Masahiro Yamada yamada.masahiro@socionext.com Acked-by: Michael Ellerman mpe@ellerman.id.au (powerpc) Tested-by: Sedat Dilek sedat.dilek@gmail.com [nc: Fix trivial conflicts in 4.19 arch/xtensa/kernel/jump_label.c doesn't exist yet Ensured CC_HAVE_ASM_GOTO and HAVE_JUMP_LABEL were sufficiently eliminated] Signed-off-by: Nathan Chancellor natechancellor@gmail.com Signed-off-by: Greg Kroah-Hartman gregkh@linuxfoundation.org
This does not matche stable-kernel rules. It is nice cleanup, but it does not really fix any bug (does it?), and resulting patch is too big.
Best regards, Pavel