On Thu, Aug 10, 2023 at 12:31:06PM -0300, Thadeu Lima de Souza Cascardo wrote:
From: Thomas Gleixner tglx@linutronix.de
Commit b3607269ff57fd3c9690cb25962c5e4b91a0fd3b upstream.
This cannot work and it's unclear how that ever made a difference.
init_fpstate.xsave.header.xfeatures is always 0 so get_xsave_addr() will always return a NULL pointer, which will prevent storing the default PKRU value in init_fpstate.
Signed-off-by: Thomas Gleixner tglx@linutronix.de Signed-off-by: Borislav Petkov bp@suse.de Reviewed-by: Borislav Petkov bp@suse.de Link: https://lkml.kernel.org/r/20210623121451.451391598@linutronix.de Reported-by: RAJESH DASARI raajeshdasari@gmail.com Signed-off-by: Thadeu Lima de Souza Cascardo cascardo@canonical.com
This has been reported to cause a WARNing since the backport of b81fac906a8f ("x86/fpu: Move FPU initialization into arch_cpu_finalize_init()").
a5eff7259790 was part of 5.2 and no older LTS kernels carry it, so not necessary on 4.19 or 4.14.
Now queued up, thanks.
greg k-h