Hello!
This is an experimental semi-automated report about issues detected by Coverity from a scan of next-20221118 as part of the linux-next scan project: https://scan.coverity.com/projects/linux-next-weekly-scan
You're getting this email because you were associated with the identified lines of code (noted below) that were touched by commits:
Thu Nov 17 00:18:25 2022 -0500 7cce4cd628be ("drm/amdgpu/mst: Stop ignoring error codes and deadlocking")
Coverity reported the following:
*** CID 1527373: Uninitialized variables (UNINIT) drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c:1227 in pre_compute_mst_dsc_configs_for_state() 1221 for (j = 0; j < dc_state->stream_count; j++) { 1222 if (dc_state->streams[j]->link == stream->link) 1223 computed_streams[j] = true; 1224 } 1225 } 1226 vvv CID 1527373: Uninitialized variables (UNINIT) vvv Using uninitialized value "ret". 1227 return ret; 1228 } 1229 1230 static int find_crtc_index_in_state_by_stream(struct drm_atomic_state *state, 1231 struct dc_stream_state *stream) 1232 {
If this is a false positive, please let us know so we can mark it as such, or teach the Coverity rules to be smarter. If not, please make sure fixes get into linux-next. :) For patches fixing this, please include these lines (but double-check the "Fixes" first):
Reported-by: coverity-bot keescook+coverity-bot@chromium.org Addresses-Coverity-ID: 1527373 ("Uninitialized variables") Fixes: 7cce4cd628be ("drm/amdgpu/mst: Stop ignoring error codes and deadlocking")
If dc_state->stream_count is 0, "ret" is undefined. Perhaps initialize it as -EINVAL?
Thanks for your attention!