On Fri, 2 Jun 2023 15:58:43 +0300 Andy Shevchenko andy.shevchenko@gmail.com wrote:
On Fri, Jun 2, 2023 at 4:25 AM Hugo Villeneuve hugo@hugovil.com wrote:
On Thu, 1 Jun 2023 20:41:40 -0400 Hugo Villeneuve hugo@hugovil.com wrote:
On Fri, 2 Jun 2023 00:30:14 +0300 andy.shevchenko@gmail.com wrote:
Thu, Jun 01, 2023 at 04:18:40PM -0400, Hugo Villeneuve kirjoitti:
...
Maybe positive one? if (mctrl_mask) regmap_update_bits(...);
I used negative to save on indentation, but it also fits by converting it to positive, so done.
I understand, but in this case it is slightly more weird to have negative conditional and in either case return the value of the local variable.
Yes.
Greg did not yet respond to my email about the proposed tags, but if the new order of the patches and the stable tags I added seems ok to you, I will resend V7. It will then probably easier for Greg to comment directly on V7 for the stable tags (Cc:).
They look fine to me, but Greg is the maintainer, he decides if it's really okay or not.
Then I will submit V7 now.
Thank you, Hugo.