Re: [PATCH] tty: xilinx_uartps: split sysrq handling

On 2025-01-10, Sean Anderson sean.anderson@linux.dev wrote:

Fix this by splitting sysrq handling into two parts. We use the prepare helper under the port lock and defer handling until we release the lock.

Note that this fix is only necessary because this console driver is using the legacy console API. For the NBCON API it is allowed to call printk() while holding the port lock.

But since code already exists to allow deferring the sysrq execution until the port lock is not held, this patch is probably a good idea anyway because it can reduce port lock contention. AFAIK there are no sysrq actions that require port lock synchronization.

Acked-by: John Ogness john.ogness@linutronix.de