On Tue, Oct 18, 2022 at 10:13:51AM +0200, Kamel Bouhara wrote:
On Mon, Oct 17, 2022 at 06:54:04PM -0400, William Breathitt Gray wrote:
The signal_read(), action_read(), and action_write() callbacks have been assuming Signal0 is requested without checking. This results in requests for Signal1 returning data for Signal0. This patch fixes these oversights by properly checking for the Signal's id in the respective callbacks and handling accordingly based on the particular Signal requested. The trig_inverted member of the mchp_tc_data is removed as superfluous.
Fixes: 106b104137fd ("counter: Add microchip TCB capture counter") Cc: stable@kernel.org Cc: Kamel Bouhara kamel.bouhara@bootlin.com Signed-off-by: William Breathitt Gray william.gray@linaro.org
Looks ok to me, thanks.
Reviewed-by: Kamel Bouhara kamel.bouhara@bootlin.com
I'm going to submit a v2 of this patch for the sake of making it a tad easier to backport and also simpler to handle if a lock is introduced at a later point for this driver.
William Breathitt Gray