On Tuesday, March 30th, 2021 at 1:53 PM, Paul Cercueil paul@crapouillou.net wrote:
I don't know about this driver but… is this really the same as the previous condition? The previous condition would match two planes, this one seems to match only a single plane. What am I missing?
There are three planes, which we will call here f0, f1, and ipu. Previously, the "plane->type == DRM_PLANE_TYPE_PRIMARY" matched f1 and ipu. Since ipu is now OVERLAY we have to change the condition or the behaviour will be different, as otherwise it would only match the f1 plane.
Oh okay, I thought f0 was one of the primary planes, but it's not. Thanks for the explanation.
For the user-space visible change:
Acked-by: Simon Ser contact@emersion.fr