On Thu, Mar 30, 2023 at 09:38:22AM -0400, Mathieu Desnoyers wrote:
commit f1a7941243c1 ("mm: convert mm's rss stats into percpu_counter") introduces a memory leak by missing a call to destroy_context() when a percpu_counter fails to allocate.
Before introducing the per-cpu counter allocations, init_new_context() was the last call that could fail in mm_init(), and thus there was no need to ever invoke destroy_context() in the error paths. Adding the following percpu counter allocations adds error paths after init_new_context(), which means its associated destroy_context() needs to be called when percpu counters fail to allocate.
Fixes: f1a7941243c1 ("mm: convert mm's rss stats into percpu_counter")
Signed-off-by: Mathieu Desnoyers mathieu.desnoyers@efficios.com Cc: Shakeel Butt shakeelb@google.com Cc: Andrew Morton akpm@linux-foundation.org Cc: Marek Szyprowski m.szyprowski@samsung.com Cc: linux-mm@kvack.org Cc: stable@vger.kernel.org # 6.2
Acked-by: Shakeel Butt shakeelb@google.com