From: Bartosz Golaszewski bgolaszewski@baylibre.com
blocking_notifier_call_chain() returns the value returned by the last registered callback. A positive return value doesn't indicate an error so check only if it's negative.
Fixes: bee1138bea15 ("nvmem: add a notifier chain") Cc: stable@vger.kernel.org Signed-off-by: Bartosz Golaszewski bgolaszewski@baylibre.com --- drivers/nvmem/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c index f7301bb4ef3b..a3bed2d9aec7 100644 --- a/drivers/nvmem/core.c +++ b/drivers/nvmem/core.c @@ -687,7 +687,7 @@ struct nvmem_device *nvmem_register(const struct nvmem_config *config) goto err_remove_cells;
rval = blocking_notifier_call_chain(&nvmem_notifier, NVMEM_ADD, nvmem); - if (rval) + if (rval < 0) goto err_remove_cells;
return nvmem;