On Mon Dec 16 19, Dan Williams wrote:
On Mon, Dec 16, 2019 at 4:59 PM Jarkko Sakkinen jarkko.sakkinen@linux.intel.com wrote:
On Wed, 2019-12-11 at 16:54 -0700, Jerry Snitselaar wrote:
Instead of repeatedly calling tpm_chip_start/tpm_chip_stop when issuing commands to the tpm during initialization, just reserve the chip after wait_startup, and release it when we are ready to call tpm_chip_register.
Cc: Christian Bundy christianbundy@fraction.io Cc: Dan Williams dan.j.williams@intel.com Cc: Peter Huewe peterhuewe@gmx.de Cc: Jarkko Sakkinen jarkko.sakkinen@linux.intel.com Cc: Jason Gunthorpe jgg@ziepe.ca Cc: Stefan Berger stefanb@linux.vnet.ibm.com Cc: stable@vger.kernel.org Cc: linux-integrity@vger.kernel.org Fixes: a3fbfae82b4c ("tpm: take TPM chip power gating out of tpm_transmit()") Fixes: 5b359c7c4372 ("tpm_tis_core: Turn on the TPM before probing IRQ's") Signed-off-by: Jerry Snitselaar jsnitsel@redhat.com
I pushed to my master with minor tweaks and added my tags.
Please check before I put it to linux-next.
I don't see it yet here:
http://git.infradead.org/users/jjs/linux-tpmdd.git/shortlog/refs/heads/maste...
However, I wanted to make sure you captured that this does *not* fix the interrupt issue. I.e. make sure you remove the "Fixes: 5b359c7c4372 ("tpm_tis_core: Turn on the TPM before probing IRQ's")" tag.
With that said, are you going to include the revert of:
1ea32c83c699 tpm_tis_core: Set TPM_CHIP_FLAG_IRQ before probing for interrupts
Dan, with the above reverted do you still get the screaming interrupt?
5b359c7c4372 tpm_tis_core: Turn on the TPM before probing IRQ's
...in your -rc3 pull?