On Tue, Feb 09, 2021 at 01:45:35PM +0100, Dafna Hirschfeld wrote:
Am 08.02.21 um 21:46 schrieb Hans Verkuil:
On 08/02/2021 18:57, Sasha Levin wrote:
From: Dafna Hirschfeld dafna.hirschfeld@collabora.com
[ Upstream commit 31f190e0ccac8b75d33fdc95a797c526cf9b149e ]
Each entry in the array is a 20 bits value composed of 16 bits unsigned integer and 4 bits fractional part. So the type should change to __u32. In addition add a documentation of how the measurements are done.
Dafna, Helen, does it make sense at all to backport these three patches to when rkisp1 was a staging driver?
I would be inclined not to backport this.
I also don't think it makes sense since this changes the uapi and it is not really a bug fix.
Why was it ok to change the uapi in a newer kernel and not an older one?
thanks,
greg k-h