On Apr 7, 2024, at 1:56 AM, Benno Lossin benno.lossin@proton.me wrote:
On 04.04.24 19:28, Laine Taffin Altman wrote:
On Apr 4, 2024, at 4:03 AM, Miguel Ojeda miguel.ojeda.sandonis@gmail.com wrote:
On Thu, Apr 4, 2024 at 11:01 AM Benno Lossin benno.lossin@proton.me wrote:
I don't see this commit in the kernel tree, what did you specify as `--base` when running `git format`?
Yeah, I don't have it either, but it seems to apply cleanly.
Cheers, Miguel
I ran `git format-patch origin/master --base=origin/master`. I can’t imagine how that could have resulted in a nonexistent commit hash?
That heavily depends on what `origin/master` is. Is `origin` pointing to Torvald's git? In that case it would explain why we don't have that commit hash yet. Normally you should base your work on the tree listed in the `T:` entry of the subsystem in the MAINTAINERS file. In our case it is `rust-next`. But no worries, since it applies cleanly it should be fine for this patch. Just something to keep in mind if you submit any future patches.
-- Cheers, Benno
Ah, that makes sense! Indeed it was pointing there. I’ll remember for next time!
Thanks, Laine