[ Sasha's backport helper bot ]
Hi,
✅ All tests passed successfully. No issues detected. No action required from the submitter.
The upstream commit SHA1 provided is correct: ab705c8c35e18652abc6239c07cf3441f03e2cda
Status in newer kernel trees: 6.15.y | Not found 6.12.y | Not found 6.6.y | Not found 6.1.y | Not found 5.15.y | Not found
Note: The patch differs from the upstream commit: --- 1: ab705c8c35e1 ! 1: 0d19deff7ec8 comedi: Fix some signed shift left operations @@ Metadata ## Commit message ## comedi: Fix some signed shift left operations
+ [ Upstream commit ab705c8c35e18652abc6239c07cf3441f03e2cda ] + Correct some left shifts of the signed integer constant 1 by some unsigned number less than 32. Change the constant to 1U to avoid shifting a 1 into the sign bit. @@ Commit message Link: https://lore.kernel.org/r/20250707121555.65424-1-abbotti@mev.co.uk Signed-off-by: Greg Kroah-Hartman gregkh@linuxfoundation.org
- ## drivers/comedi/drivers.c ## -@@ drivers/comedi/drivers.c: int comedi_dio_insn_config(struct comedi_device *dev, + ## drivers/staging/comedi/drivers.c ## +@@ drivers/staging/comedi/drivers.c: int comedi_dio_insn_config(struct comedi_device *dev, unsigned int *data, unsigned int mask) { @@ drivers/comedi/drivers.c: int comedi_dio_insn_config(struct comedi_device *dev,
switch (data[0]) { case INSN_CONFIG_DIO_INPUT: -@@ drivers/comedi/drivers.c: EXPORT_SYMBOL_GPL(comedi_dio_insn_config); +@@ drivers/staging/comedi/drivers.c: EXPORT_SYMBOL_GPL(comedi_dio_insn_config); unsigned int comedi_dio_update_state(struct comedi_subdevice *s, unsigned int *data) { @@ drivers/comedi/drivers.c: EXPORT_SYMBOL_GPL(comedi_dio_insn_config); : 0xffffffff; unsigned int mask = data[0] & chanmask; unsigned int bits = data[1]; -@@ drivers/comedi/drivers.c: static int insn_rw_emulate_bits(struct comedi_device *dev, +@@ drivers/staging/comedi/drivers.c: static int insn_rw_emulate_bits(struct comedi_device *dev, if (insn->insn == INSN_WRITE) { if (!(s->subdev_flags & SDF_WRITABLE)) return -EINVAL; @@ drivers/comedi/drivers.c: static int insn_rw_emulate_bits(struct comedi_device * }
ret = s->insn_bits(dev, s, &_insn, _data); -@@ drivers/comedi/drivers.c: static int __comedi_device_postconfig(struct comedi_device *dev) +@@ drivers/staging/comedi/drivers.c: static int __comedi_device_postconfig(struct comedi_device *dev)
if (s->type == COMEDI_SUBD_DO) { if (s->n_chan < 32)
---
Results of testing on various branches:
| Branch | Patch Apply | Build Test | |---------------------------|-------------|------------| | origin/linux-5.10.y | Success | Success |