Hi,
On 4/3/23 22:51, Maxim Mikityanskiy wrote:
On Fri, 31 Mar 2023 at 12:51:30 +0300, Maxim Mikityanskiy wrote:
On Thu, 30 Mar 2023 at 21:46:44 +0200, Hans de Goede wrote:
Commit 5829f8a897e4 ("platform/x86: ideapad-laptop: Send KEY_TOUCHPAD_TOGGLE on some models") made ideapad-laptop send KEY_TOUCHPAD_TOGGLE when we receive an ACPI notify with VPC event bit 5 set and the touchpad-state has not been changed by the EC itself already.
This was done under the assumption that this would be good to do to make the touchpad-toggle hotkey work on newer models where the EC does not toggle the touchpad on/off itself (because it is not routed through the PS/2 controller, but uses I2C).
But it turns out that at least some models, e.g. the Yoga 7-15ITL5 the EC triggers an ACPI notify with VPC event bit 5 set on resume, which would now cause a spurious KEY_TOUCHPAD_TOGGLE on resume to which the desktop environment responds by disabling the touchpad in software, breaking the touchpad (until manually re-enabled) on resume.
Oh gosh, the touchpad toggle on Ideapads is so much broken, I wonder how the Windows driver deals with all this variety of different behaviors (unless it's broken too :D).
I'll test the patch on Z570, but as I see, it shouldn't change anything for Z570.
Tested the kernel from your branch on Z570, the touchpad button still works fine.
Thank you for testing.
Regards,
Hans