8 Apr
2025
8 Apr
'25
12:24 p.m.
Marc Kleine-Budde mkl@pengutronix.de writes:
On 31.03.2025 09:25:26, Axel Forsman wrote:
-static u32 kvaser_pciefd_receive_irq(struct kvaser_pciefd *pcie) +static void kvaser_pciefd_receive_irq(struct kvaser_pciefd *pcie) {
- __le32 __iomem *srb_cmd_reg = KVASER_PCIEFD_SRB_ADDR(pcie) + KVASER_PCIEFD_SRB_CMD_REG;
Why is this an __le32? The struct kvaser_pciefd::reg_base is __iomem void *.
Just as a hint that the register is 32-bit. But you are right, I will change to "void __iomem *" for consistency in the next iteration.
/Axel