RE: [PATCH AUTOSEL 5.1 08/39] arm64: dts: ls1028a: Fix CPU idle fail.

Hi Sasha,

Thanks for helping port this patch to stable. May I know if I can submit other bug fixes which has been accepted by upstream to stable by myself? If yes, where I can find related process for reference?

Thanks & Regards, Ran

-----Original Message----- From: Sasha Levin sashal@kernel.org Sent: Wednesday, July 03, 2019 10:15 To: linux-kernel@vger.kernel.org; stable@vger.kernel.org Cc: Ran Wang ran.wang_1@nxp.com; Shawn Guo shawnguo@kernel.org; Sasha Levin sashal@kernel.org; devicetree@vger.kernel.org Subject: [PATCH AUTOSEL 5.1 08/39] arm64: dts: ls1028a: Fix CPU idle fail.

From: Ran Wang ran.wang_1@nxp.com

[ Upstream commit 53f2ac9d3aa881ed419054076042898b77c27ee4 ]

PSCI spec define 1st parameter's bit 16 of function CPU_SUSPEND to indicate CPU State Type: 0 for standby, 1 for power down. In this case, we want to select standby for CPU idle feature. But current setting wrongly select power down and cause CPU SUSPEND fail every time. Need this fix.

Fixes: 8897f3255c9c ("arm64: dts: Add support for NXP LS1028A SoC") Signed-off-by: Ran Wang ran.wang_1@nxp.com Signed-off-by: Shawn Guo shawnguo@kernel.org Signed-off-by: Sasha Levin sashal@kernel.org

---

arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi index 2896bbcfa3bb..228872549f01 100644 --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi @@ -28,7 +28,7 @@ enable-method = "psci"; clocks = <&clockgen 1 0>; next-level-cache = <&l2>;

• 	cpu-idle-states = <&CPU_PH20>;
  

• 	cpu-idle-states = <&CPU_PW20>;
  

  };

  cpu1: cpu@1 {

@@ -38,7 +38,7 @@ enable-method = "psci"; clocks = <&clockgen 1 0>; next-level-cache = <&l2>;

• 	cpu-idle-states = <&CPU_PH20>;
  

• 	cpu-idle-states = <&CPU_PW20>;
  

  };

  l2: l2-cache {

@@ -53,13 +53,13 @@ */ entry-method = "arm,psci";

• CPU_PH20: cpu-ph20 {
  

• 	compatible = "arm,idle-state";
  

• 	idle-state-name = "PH20";
  

• 	arm,psci-suspend-param = <0x00010000>;
  

• 	entry-latency-us = <1000>;
  

• 	exit-latency-us = <1000>;
  

• 	min-residency-us = <3000>;
  

• CPU_PW20: cpu-pw20 {
  

• 	  compatible = "arm,idle-state";
  

• 	  idle-state-name = "PW20";
  

• 	  arm,psci-suspend-param = <0x0>;
  

• 	  entry-latency-us = <2000>;
  

• 	  exit-latency-us = <2000>;
  

• 	  min-residency-us = <6000>;
  

  }; };

-- 2.20.1