On Tue, Oct 8, 2024 at 4:06 PM Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
On Tue, Oct 08, 2024 at 03:05:41PM +0200, Sedat Dilek wrote:
On Tue, Oct 8, 2024 at 3:01 PM Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
6.11-stable review patch. If anyone has any objections, please let me know.
From: Arnaldo Carvalho de Melo acme@redhat.com
commit 00dc514612fe98cfa117193b9df28f15e7c9db9c upstream.
The -Wcast-function-type-mismatch option was introduced in clang 19 and its enabled by default, since we use -Werror, and python bindings do casts that are valid but trips this warning, disable it if present.
Closes: https://lore.kernel.org/all/CA+icZUXoJ6BS3GMhJHV3aZWyb5Cz2haFneX0C5pUMUUhG-U... Reported-by: Sedat Dilek sedat.dilek@gmail.com Tested-by: Sedat Dilek sedat.dilek@gmail.com Cc: Ian Rogers irogers@google.com Cc: Ingo Molnar mingo@redhat.com Cc: Namhyung Kim namhyung@kernel.org Cc: Nathan Chancellor nathan@kernel.org Cc: Peter Zijlstra peterz@infradead.org Cc: stable@vger.kernel.org # To allow building with the upcoming clang 19 Link: https://lore.kernel.org/lkml/CA+icZUVtHn8X1Tb_Y__c-WswsO0K8U9uy3r2MzKXwTA5TH... Signed-off-by: Arnaldo Carvalho de Melo acme@redhat.com Signed-off-by: Greg Kroah-Hartman gregkh@linuxfoundation.org
tools/perf/util/setup.py | 2 ++ 1 file changed, 2 insertions(+)
--- a/tools/perf/util/setup.py +++ b/tools/perf/util/setup.py @@ -63,6 +63,8 @@ cflags = getenv('CFLAGS', '').split() cflags += ['-fno-strict-aliasing', '-Wno-write-strings', '-Wno-unused-parameter', '-Wno-redundant-decls' ] if cc_is_clang: cflags += ["-Wno-unused-command-line-argument" ]
- if clang_has_option("-Wno-cast-function-type-mismatch"):
cflags += ["-Wno-cast-function-type-mismatch" ]else: cflags += ['-Wno-cast-function-type' ]
( I already responded to a stable-commits email sent to me, but here might be better. )
Hi Greg,
You need both patches:
upstream 00dc514612fe98cfa117193b9df28f15e7c9db9c "perf python: Disable -Wno-cast-function-type-mismatch if present on clang" ^^ You have only this one - sets only the warning flag
upstream b81162302001f41157f6e93654aaccc30e817e2a "perf python: Allow checking for the existence of warning" ^^ Add this please to all stable trees affected, Thanks.
Explanations in [1] and initial report in [2].
Thanks, now queued up!
greg k-h
Cool, that will be a nice stable-linux version 6.11.3 for us!
-sed@-