Re: [PATCH v3 07/10] net/mlx5: Use RMW accessors for changing LNKCTL

On Tue, Jun 20, 2023 at 04:46:21PM +0300, Ilpo Järvinen wrote:

Don't assume that only the driver would be accessing LNKCTL of the upstream bridge. ASPM policy changes can trigger write to LNKCTL outside of driver's control.

Use RMW capability accessors which do proper locking to avoid losing concurrent updates to the register value.

Fixes: eabe8e5e88f5 ("net/mlx5: Handle sync reset now event") Suggested-by: Lukas Wunner lukas@wunner.de Signed-off-by: Ilpo Järvinen ilpo.jarvinen@linux.intel.com Reviewed-by: Moshe Shemesh moshe@nvidia.com Cc: stable@vger.kernel.org

---

drivers/net/ethernet/mellanox/mlx5/core/fw_reset.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-)

Reviewed-by: Simon Horman simon.horman@corigine.com