On Thu, Jun 28, 2018 at 04:24:24PM +0200, Jiri Slaby wrote:
On 03/28/2018, 05:35 PM, David Miller wrote:
Please queue up the following networking bug fixes for v4.14 and v4.15 -stable, respecetively.
Hi,
I wonder if this commit from this batch is correct in 4.14 and 4.15: commit 5bbb99d2fde047df596379be6c58e265e2ddbe1f Author: Madalin Bucur madalin.bucur@nxp.com Date: Wed Mar 14 08:37:29 2018 -0500
dpaa_eth: fix error in dpaa_remove() [ Upstream commit 88075256ee817041d68c2387f29065b5cb2b342a ]In 4.14 and 4.15, the drvdata are set like this: dev = &pdev->dev; … dev_set_drvdata(dev, net_dev);
Opposing to 4.16: dev = pdev->dev.parent; … dev_set_drvdata(dev, net_dev);
So the change in dpaa_remove done by the commit above is wrong IMO:
dev = &pdev->dev;
dev = pdev->dev.parent; net_dev = dev_get_drvdata(dev);Hence this should be reverted from 4.14-LTS. I think 4.15 is dead.
Now reverted, thanks.
greg k-h