Re: [PATCH] mm/page_alloc: fix memalloc_nocma_{save/restore} APIs

2020년 7월 21일 (화) 오후 9:39, Vlastimil Babka vbabka@suse.cz님이 작성:

On 7/21/20 2:05 PM, Matthew Wilcox wrote:

...

On Tue, Jul 21, 2020 at 12:28:49PM +0900, js1304@gmail.com wrote:

...

+static inline unsigned int current_alloc_flags(gfp_t gfp_mask,

•                                unsigned int alloc_flags)
  

+{ +#ifdef CONFIG_CMA

• unsigned int pflags = current->flags;
• if (!(pflags & PF_MEMALLOC_NOCMA) &&

•        gfp_migratetype(gfp_mask) == MIGRATE_MOVABLE)
  

•        alloc_flags |= ALLOC_CMA;
  

Please don't indent by one tab when splitting a line because it looks like the second line and third line are part of the same block. Either do this:

  if (!(pflags & PF_MEMALLOC_NOCMA) &&
      gfp_migratetype(gfp_mask) == MIGRATE_MOVABLE)
          alloc_flags |= ALLOC_CMA;

or this: if (!(pflags & PF_MEMALLOC_NOCMA) && gfp_migratetype(gfp_mask) == MIGRATE_MOVABLE) alloc_flags |= ALLOC_CMA;

Ah, good point.

Will change it.

Thanks.