On 2024/8/20 0:59, Bart Van Assche wrote:
On 8/19/24 2:09 AM, Yihang Li wrote:
if ((sshdr.asc == 0x04 && sshdr.ascq == 0x04) ||Shouldn't symbolic names be introduced for these numeric constants? Although there is more code in the SCSI core that compares ASC / ASCQ values with numeric constants, I think we need symbolic names for these constants to make code like the above easier to read. There is already a header file for definitions that come directly from the SCSI standard and that is used by both SCSI initiator and SCSI target code: <scsi/scsi_proto.h>.
My idea is to be consistent with the style of the code context. That's why I use numerical values.
If we want to use symbolic names to replace all numeric constants, I think that would be another series of patches, and the changes would be more.
Thanks,
Yihang.