Re: [PATCH 4.14 19/26] fbdev: imsttfb: Release framebuffer and dealloc cmap on error path

On Wed, Jun 28, 2023 at 11:41:33PM +0200, Helge Deller wrote:

Hi Greg & Sasha,

The patch below landed in 4.14-stable and breaks build with this error:

drivers/video/fbdev/imsttfb.c:1457:3: error: void function 'init_imstt' should not return a value [-Wreturn-type] return -ENODEV; ^ ~~~~~~~ 1 error generated.

I suggest to simply drop (revert) it again from the v4.14-stable tree. Shall I send a revert-patch, or can you do it manually?

How about just fix it up by changing the line to "return;" instead?

thanks,

greg k-h