Hi,
On Thu, Feb 29, 2024 at 9:13 AM Mark Brown broonie@kernel.org wrote:
On Thu, Feb 29, 2024 at 08:51:09AM -0800, Doug Anderson wrote:
As I mentioned [1], there's a hidden dependency here and without it the patch doesn't actually do anything useful in kernel 6.6 nor kernel 6.1. Maybe the right answer is to backport this with the hardcoded value of "16" for those older kernels? Maybe Mark has a better suggestion?
Your suggestion should be fine.
Crud. Ignore me. The patch is fine as-is for 6.1, 6.6, and 6.7. :(
git tag --contains f171f9e4097d ...shows that the needed patch is actually in 5.19+
Instead of using the above "git tag --contains", I was naively just running:
git grep ZCR_ELx_LEN_SIZE
...and I saw that it still came back 9 on v6.6. ...but that's because it was still set as 9 in the tools directory and I didn't notice.
Sorry for the noise. We could still do the hardcoded solution of defining it as 16 for 5.15 and older if folks want.
-Doug