On 11/10/25 15:51, Johan Hovold wrote:
Hi Daniel,
On Wed, Nov 05, 2025 at 02:32:18PM +0100, Daniel Lezcano wrote:
You should replace __init by __init_or_module
That's not sufficient as the driver can still be rebound through sysfs currently (the driver would probably crash anyway, but that's a separate issue).
Also note that no drivers use __init_or_module these days, likely as everyone uses modules and it's not worth the added complexity in trying to get the section markers right for a build configuration that few people care about.
I can send a follow-on patch to suppress the unbind attribute, or include it in a v2 if you insist on using __init_or_module.
What do you prefer?
I think it makes sens to use __init_or_module because these drivers have been always compiled in and we are converting them into modules.
[ ... ]