From: Talhah Peerbhai talhah.peerbhai@gmail.com
[ Upstream commit a28206060dc5848a1a2a15b7f6ac6223d869084d ]
Similar to many other Lenovo models with AMD chips, the Lenovo Yoga Pro 7 14ASP9 (product name 83HN) requires a specific quirk to ensure internal mic detection. This patch adds a quirk fixing this.
Signed-off-by: Talhah Peerbhai talhah.peerbhai@gmail.com Link: https://patch.msgid.link/20250515222741.144616-1-talhah.peerbhai@gmail.com Signed-off-by: Mark Brown broonie@kernel.org Signed-off-by: Sasha Levin sashal@kernel.org ---
Based on my analysis of the commit and comparison with the similar historical commits, here is my assessment: **YES** This commit should be backported to stable kernel trees for the following reasons: ## Code Analysis **1. Nature of the Change:** The commit adds a single quirk entry for the Lenovo Yoga Pro 7 14ASP9 (product name "83HN") to the `yc_acp_quirk_table[]` array in `sound/soc/amd/yc/acp6x-mach.c`. The change is minimal and contained: ```c + { + .driver_data = &acp6x_card, + .matches = { + DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"), + DMI_MATCH(DMI_PRODUCT_NAME, "83HN"), + } + }, ``` **2. Meets Stable Tree Criteria:** - **Device ID Addition**: This is explicitly mentioned in the stable kernel rules as acceptable - "It must either fix a real bug that bothers people or just add a device ID" - **Under 100 lines**: The change is only 7 lines with context - **Obviously correct**: The pattern matches exactly what's used for dozens of other Lenovo models - **Fixes real user issue**: Internal microphone non-functionality is a clear hardware regression/bug that affects users **3. Historical Precedent:** All 5 similar commits provided as examples received "Backport Status: YES". They all follow the exact same pattern: - Similar commit subjects mentioning specific Lenovo models - Identical code structure adding DMI quirk entries - Same commit messages describing microphone functionality fixes - Several explicitly included `Cc: stable@vger.kernel.org` tags **4. Risk Assessment:** - **Minimal regression risk**: Adding a quirk entry cannot break existing functionality - **Contained change**: Only affects the specific Lenovo model 83HN - **Well-established pattern**: This quirk mechanism is proven stable across dozens of similar entries **5. User Impact:** The commit message clearly states this fixes internal microphone detection on a specific laptop model. Non-functional audio hardware represents a significant user-facing issue that stable trees are meant to address. **6. Code Quality:** The change also includes a minor whitespace fix (replacing spaces with tab for consistency), showing attention to code quality without introducing functional changes. This commit perfectly matches the stable tree criteria: it's a small, safe device ID addition that fixes a real user- affecting hardware issue with minimal risk of regression.
sound/soc/amd/yc/acp6x-mach.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c index 622df58a96942..9fdee74c28df2 100644 --- a/sound/soc/amd/yc/acp6x-mach.c +++ b/sound/soc/amd/yc/acp6x-mach.c @@ -311,6 +311,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = { DMI_MATCH(DMI_PRODUCT_NAME, "83AS"), } }, + { + .driver_data = &acp6x_card, + .matches = { + DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"), + DMI_MATCH(DMI_PRODUCT_NAME, "83HN"), + } + }, { .driver_data = &acp6x_card, .matches = { @@ -360,7 +367,7 @@ static const struct dmi_system_id yc_acp_quirk_table[] = { DMI_MATCH(DMI_PRODUCT_NAME, "M5402RA"), } }, - { + { .driver_data = &acp6x_card, .matches = { DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER INC."),