29 Jan
2025
29 Jan
'25
11:52 a.m.
On Wed, 2025-01-29 at 14:50 +0300, Dmitry Antipov wrote:
On 1/29/25 1:48 PM, Johannes Berg wrote:
I don't see that there's uninitialized use of 'len'. Maybe some static checkers aren't seeing through this, but the code is fine:
If iwl_pnvm_get_from_fs() is successful, then 'len' is initialized. If it fails, we goto skip_parse.
[... reordering too ...]
Am I missing something?
You missed this:
There, if trans->reduce_power_loaded is false, 'len' again is either initialized or we go to skip_reduce_power and never use 'len'.
If trans->reduce_power_loaded is true, then we get to iwl_trans_pcie_ctx_info_gen3_set_reduce_power() which doesn't use 'len' in this case.
johannes