Hello Greg,
Thanks for the notification.
BR, Sagar
-----Original Message----- From: gregkh@linuxfoundation.org gregkh@linuxfoundation.org Sent: Friday, May 15, 2020 6:25 PM To: Sagar Kadam sagar.kadam@sifive.com; Atish.Patra@wdc.com; gregkh@linuxfoundation.org; palmerdabbelt@google.com; stable@vger.kernel.org Subject: patch "tty: serial: add missing spin_lock_init for SiFive serial console" added to tty-linus
[External Email] Do not click links or attachments unless you recognize the sender and know the content is safe
This is a note to let you know that I've just added the patch titled
tty: serial: add missing spin_lock_init for SiFive serial consoleto my tty git tree which can be found at git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git in the tty-linus branch.
The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)
The patch will hopefully also be merged in Linus's tree for the next -rc kernel release.
If you have any questions about this process, please let me know.
From 17b4efdf4e4867079012a48ca10d965fe9d68822 Mon Sep 17 00:00:00 2001 From: Sagar Shrikant Kadam sagar.kadam@sifive.com Date: Sat, 9 May 2020 03:24:12 -0700 Subject: tty: serial: add missing spin_lock_init for SiFive serial console
An uninitialised spin lock for sifive serial console raises a bad magic spin_lock error as reported and discussed here [1]. Initialising the spin lock resolves the issue.
The fix is tested on HiFive Unleashed A00 board with Linux 5.7-rc4 and OpenSBI v0.7
[1] https://lore.kernel.org/linux- riscv/b9fe49483a903f404e7acc15a6efbef756db28ae.camel@wdc.com
Fixes: 45c054d0815b ("tty: serial: add driver for the SiFive UART") Reported-by: Atish Patra Atish.Patra@wdc.com Signed-off-by: Sagar Shrikant Kadam sagar.kadam@sifive.com Reviewed-by: Palmer Dabbelt palmerdabbelt@google.com Acked-by: Palmer Dabbelt palmerdabbelt@google.com Cc: stable stable@vger.kernel.org Link: https://lore.kernel.org/r/1589019852-21505-2-git-send-email- sagar.kadam@sifive.com Signed-off-by: Greg Kroah-Hartman gregkh@linuxfoundation.org
drivers/tty/serial/sifive.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/tty/serial/sifive.c b/drivers/tty/serial/sifive.c index 13eadcb8aec4..0b5110dad051 100644 --- a/drivers/tty/serial/sifive.c +++ b/drivers/tty/serial/sifive.c @@ -883,6 +883,7 @@ console_initcall(sifive_console_init);
static void __ssp_add_console_port(struct sifive_serial_port *ssp) {
spin_lock_init(&ssp->port.lock); sifive_serial_console_ports[ssp->port.line] = ssp;}
-- 2.26.2