Re: [PATCH 1/6] xfs: don't move nondir/nonreg temporary repair files to the metadir namespace

On Tue, Dec 03, 2024 at 07:02:29PM -0800, Darrick J. Wong wrote:

From: Darrick J. Wong djwong@kernel.org

Only directories or regular files are allowed in the metadata directory tree. Don't move the repair tempfile to the metadir namespace if this is not true; this will cause the inode verifiers to trip.

Shouldn't this be an error instead of silently returning? Either way the function could probably use a lot more comments explaining what is doing and why.