8 Apr
2021
8 Apr
'21
1:30 p.m.
On 3/29/2021 10:11 AM, Jason Gunthorpe wrote:
On Mon, Mar 29, 2021 at 09:48:18AM -0400, dennis.dalessandro@cornelisnetworks.com wrote:
From: Kaike Wan kaike.wan@intel.com
Call xa_destroy for hfi1_dev_table before unloading the module to avoid a potential memory leak.
Do you hit the WARN_ON or not?
Is this all just mindless?
If the xarray is supposed to be empty because everything was erased then you don't need it, the WARN_ON is correct. An empty xarray needs no further destruction.
Looking at our internal bug that corresponds to this change, I don't see a WARN_ON that had been hit. I think we should just go ahead and drop these two patches for now and if we do hit the WARN_ON we will revisit.
-Denny