On Wed, Sep 01, 2021 at 11:13:01AM +0800, Chen-Yu Tsai wrote:
On Wed, Sep 1, 2021 at 2:48 AM Jernej Skrabec jernej.skrabec@gmail.com wrote:
Macros SUN8I_CSC_CTRL() and SUN8I_CSC_COEFF() don't follow usual recommendation of having arguments enclosed in parenthesis. While that didn't change anything for quiet sometime, it actually become important
^ Typoafter CSC code rework with commit ea067aee45a8 ("drm/sun4i: de2/de3: Remove redundant CSC matrices").
Without this fix, colours are completely off for supported YVU formats on SoCs with DE2 (A64, H3, R40, etc.).
Fix the issue by enclosing macro arguments in parenthesis.
Cc: stable@vger.kernel.org # 5.12+ Fixes: 883029390550 ("drm/sun4i: Add DE2 CSC library") Reported-by: Roman Stratiienko r.stratiienko@gmail.com Signed-off-by: Jernej Skrabec jernej.skrabec@gmail.com
Otherwise,
Reviewed-by: Chen-Yu Tsai wens@csie.org
Fixed the typo and applied, thanks Maxime