On Fri, Jun 6, 2025 at 3:20 PM Greg KH gregkh@linuxfoundation.org wrote:
On Fri, Jun 06, 2025 at 03:08:09PM +0900, Suleiman Souhlal wrote:
On Fri, Jun 6, 2025 at 3:05 PM Greg KH gregkh@linuxfoundation.org wrote:
On Fri, Jun 06, 2025 at 02:36:50PM +0900, Suleiman Souhlal wrote:
When cross compiling the kernel with clang, we need to override CLANG_CROSS_FLAGS when preparing the step libraries for resolve_btfids.
Prior to commit d1d096312176 ("tools: fix annoying "mkdir -p ..." logs when building tools in parallel"), MAKEFLAGS would have been set to a value that wouldn't set a value for CLANG_CROSS_FLAGS, hiding the fact that we weren't properly overriding it.
Cc: stable@vger.kernel.org Fixes: 56a2df7615fa ("tools/resolve_btfids: Compile resolve_btfids as host program") Signed-off-by: Suleiman Souhlal suleiman@google.com
tools/bpf/resolve_btfids/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
You forgot to say why this is a resend :(
I wasn't sure how to say it. It didn't occur to me that I could have replied to it with the reason.
That goes below the --- line and it would be a v2, not a RESEND as you changed something:
It was because I had "Signed-of-by:" instead of "Signed-off-by:".
Which means it was not identical to the first version (a RESEND means a maintainer can take either as they are the same).
Ah. Should I resend it as a v2?
Thanks, -- Suleiman