6 Dec
2018
6 Dec
'18
12:16 p.m.
Hi, 在 2018/12/6 20:04, John Garry 写道:
On 06/12/2018 04:17, Martin K. Petersen wrote:
Bart,
Had you considered to use lower_32_bits() instead of "0xffffffff"? That would to avoid that reviewers have to count the 'f'-s to verify correctness of t10_pi_ref_tag().
I hadn't. I guess I tend to think of lower_32_bits() as something you do to pointers, not to block numbers.
Xiang Chen tested the patch successfully. I'll let him provide tested-by tag.
I have tested the patch with running fio on 3008 (on our ARM64 board with 4 DIF disks and 8 non-DIF disks), and now it works well. Tested-by: Xiang Chen chenxiang66@hisilicon.com
Thanks, John
.